-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Create sample Java project using SDK. WPB-19280 #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend WireEventsHandlerDefault Reply the message with the same content with a minimal addition to the end.
bbaarriiss
commented
Aug 20, 2025
sample-java/src/main/java/org/example/CustomWireEventsHandler.java
Outdated
Show resolved
Hide resolved
sample-java/src/main/java/org/example/CustomWireEventsHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and clean, just got one strange comment 👀
remove empty lines
spoonman01
requested changes
Aug 20, 2025
sample-java/src/main/java/org/example/CustomWireEventsHandler.java
Outdated
Show resolved
Hide resolved
Remove ChatService and simplify the flow.
Use Java 17 instead of 21
spoonman01
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification caused by moving ChatService logic into Events handler
sample-java/src/main/java/org/example/CustomWireEventsHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a sample code (using the SDK) written in Java language.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
This PR contains a sample code (using the SDK) written in Java language.
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.