feat: create channel conversation #WPB-19530 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new attributes for Create Conversation Request (add_permission, team and skip_creator) * Add new error type and handling for Operation Denied when user doesn't have permission to create a Channel * Update API Version to v10 * Add a new method in ConversationService for creating a Channel * Add javadocs for creating a conversation in WireApplicationManager * Add tests for creating a Channel * Add sample for creating a Channel and keep current placeholder TeamId to be passed
spoonman01
reviewed
Aug 25, 2025
...c/main/kotlin/com/wire/integrations/jvm/model/http/conversation/CreateConversationRequest.kt
Outdated
Show resolved
Hide resolved
sample/sample-kotlin/src/main/kotlin/com/wire/integrations/sample/SampleEventsHandler.kt
Outdated
Show resolved
Hide resolved
lib/src/test/kotlin/com/wire/integrations/jvm/service/WireApplicationManagerTest.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/wire/integrations/jvm/service/conversation/ConversationService.kt
Show resolved
Hide resolved
* Add createChannel example in APPLICATION.md * Remove default value for groupConversationType in CreateConversationRequest and pass each value when needed * Add comment for logic when updating key material or adding members to a conversation * Update conversation type in One to One response for tests * Add receiving TEAM_ID when creating a channel in the sample project
bbaarriiss
approved these changes
Aug 26, 2025
lib/src/main/kotlin/com/wire/integrations/jvm/service/conversation/ConversationService.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/wire/integrations/jvm/service/conversation/ConversationService.kt
Outdated
Show resolved
Hide resolved
* Rename `conversationResponse` to `conversationCreatedResponse` * Add a new extension function for ConversationResponse to decode groupId to MlsGroupId
* Fix ktlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No way to create a Channel conversation
Causes (Optional)
Not implemented yet
Solutions
Added a new method on
ConversationServicethat will be available externally throughWireApplicationManagercalledcreateChannel/CreateChannelConversation.Currently keeping the
TeamIdto be passed on the method parameters until we have more information about handling multiple teams for the same user.Testing
Test Coverage (Optional)
How to Test
create-channel-conversation [NAME] [USER_ID] [DOMAIN]