Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert WireLinkPreview to Swift Package - WPB-10570 #1796

Open
wants to merge 64 commits into
base: develop
Choose a base branch
from
Open

chore: convert WireLinkPreview to Swift Package - WPB-10570 #1796

wants to merge 64 commits into from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Aug 13, 2024 •
edited by github-actions bot
Loading

TaskWPB-10570 Convert WireLinkPreview to SPM

Issue

This PR converts WireLinkPreview from an Xcode project to a Swift package.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

caldrian added 20 commits August 13, 2024 11:15
@caldrian
delete the Collection+element(atIndex:) method
3cdcf51
@caldrian
remove dependency
f6f1aca
@caldrian
create Swift package for WireLinkPreview
46fa8ee
@caldrian
configure package
b812034
@caldrian
add dependency to HTMLString
ea8105f
@caldrian
move files into the package
e5daff5
@caldrian
fix workflow definitions
edcb725
@caldrian
add missing imports
277520d
@caldrian
fix build errors
006ac56
@caldrian
Merge branch 'chore/cleanup-array+safeindex-WPB-10570' into chore/con…
b585f4e 
…vert-link-preview-to-package-WPB-10570
@caldrian
create TextMessageData protocol in Swift
a8e0a4c
@caldrian
create TextMessage.swift
988628c
@caldrian
convert more code
23e09c8
@caldrian
Trigger CI
69816f6
@caldrian
fix build errors
091f6ec
@caldrian
fix warnings
88895bf
@caldrian
add typealias
4bc9bd4
@caldrian
remove typealias
febc54b
@caldrian
Merge branch 'chore/cleanup-array+safeindex-WPB-10570' into chore/con…
108b64b 
…vert-ZMTextMessageData-to-Swift-WPB-10570
@caldrian
Merge branch 'chore/convert-ZMTextMessageData-to-Swift-WPB-10570' int…
c49947d 
…o chore/convert-link-preview-to-package-WPB-10570
@caldrian caldrian changed the base branch from develop to chore/convert-ZMTextMessageData-to-Swift-WPB-10570 August 13, 2024 12:07
caldrian and others added 8 commits August 13, 2024 14:20
@caldrian
minor fixes
46d97c1
@caldrian
Merge branch 'gh-readonly-queue/develop/pr-1794-81c52c632f7782c4200fe…
fd5b389 
…6569a823a283f7083f7' of github.com:wireapp/wire-ios into chore/convert-ZMTextMessageData-to-Swift-WPB-10570
@caldrian
Merge branch 'chore/convert-ZMTextMessageData-to-Swift-WPB-10570' int…
d5a0e54 
…o chore/convert-link-preview-to-package-WPB-10570
@caldrian
fix swiftlint warnings
1c3e8fd
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/conv…
491bf68 
…ert-ZMTextMessageData-to-Swift-WPB-10570
@caldrian
Merge branch 'develop' into chore/convert-ZMTextMessageData-to-Swift-…
06fd828 
…WPB-10570
@caldrian
Merge commit 'eb2df338767f4a234ae71c8d0f7935ef2f45da19' into chore/co…
e797389 
…nvert-ZMTextMessageData-to-Swift-WPB-10570
@caldrian
Merge branch 'chore/convert-ZMTextMessageData-to-Swift-WPB-10570' int…
3e9c803 
…o chore/convert-link-preview-to-package-WPB-10570
caldrian and others added 18 commits September 6, 2024 09:18
@caldrian
add test
662ce8f
@caldrian
run tests
a64cdd3
@caldrian
format code
22eead2
@caldrian
Merge branch 'chore/trim-string-catalogs-WPB-10903' into chore/create…
5730de6 
…-wire-foundation-WPB-10903
@caldrian
Merge branch 'develop' into chore/trim-string-catalogs-WPB-10903
2edce86
@caldrian
fix workflow definitions
1897474
@caldrian
fix workflow definitions
fd32c48
@caldrian
Merge branch 'chore/trim-string-catalogs-WPB-10903' into chore/create…
6b36774 
…-wire-foundation-WPB-10903
@caldrian
Trigger CI
953c2ff
@caldrian
Merge branch 'chore/trim-string-catalogs-WPB-10903' into chore/create…
613d89d 
…-wire-foundation-WPB-10903
@caldrian
remove duplicate input parameter specification
f4292e7
@caldrian
fix settings swiftSettings
9c2a9ee
@caldrian
add missing any
96f73d6
@caldrian
Merge branch 'fix/swift-settings-in-package-targets-WPB-10949' into c…
0be1a08 
…hore/trim-string-catalogs-WPB-10903
@caldrian
Merge branch 'chore/trim-string-catalogs-WPB-10903' into chore/create…
1c97324 
…-wire-foundation-WPB-10903
@caldrian
cleanup project files
0721ddb
@caldrian
Merge branch 'chore/create-wire-foundation-WPB-10903' into chore/conv…
68cc9ef 
…ert-link-preview-to-package-WPB-10570
@caldrian
format code
417779a
@caldrian caldrian changed the base branch from develop to chore/create-wire-foundation-WPB-10903 September 6, 2024 10:11
Base automatically changed from chore/create-wire-foundation-WPB-10903 to develop September 9, 2024 20:44
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Oct 10, 2024
@github-actions github-actions bot removed the stale label Nov 15, 2024
@caldrian
Copy link
Contributor Author

caldrian commented Nov 20, 2024 •
edited
Loading

Apart from resolving the conflicts what's missing for this PR to be done is fixing or deleting the WireLinkPreview.E2ETests.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Dec 21, 2024
@github-actions github-actions bot removed the stale label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caldrian caldrian

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caldrian