Skip to content

feat: Add sha256 in CI for C builds - WPB-11313#2314

Merged
netbe merged 2 commits intorelease/cycle-3.112from
chore/add-sha256-c-builds-cherry-picks
Jan 6, 2025
Merged

feat: Add sha256 in CI for C builds - WPB-11313#2314
netbe merged 2 commits intorelease/cycle-3.112from
chore/add-sha256-c-builds-cherry-picks

Conversation

@KaterinaWire
Copy link
Copy Markdown
Contributor

@KaterinaWire KaterinaWire commented Dec 18, 2024 •
edited by github-actions Bot
Loading

TaskWPB-11313 Add sha256 in iOS CI especially for C builds

Issue

This PR was cherry-picked based on the following PR:

#2269

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@KaterinaWire KaterinaWire requested a review from netbe December 18, 2024 16:02
@echoes-hq echoes-hq Bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Dec 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5e6ca45.

♻️ This comment has been updated with latest results.

netbe
netbe reviewed Dec 19, 2024
View reviewed changes
Comment thread .github/workflows/_reusable_app_release.yml Outdated
netbe
netbe approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor thing to remove

@KaterinaWire KaterinaWire enabled auto-merge (squash) December 27, 2024 13:33
@netbe netbe disabled auto-merge January 6, 2025 13:57
@netbe netbe merged commit 833ac32 into release/cycle-3.112 Jan 6, 2025
@netbe netbe deleted the chore/add-sha256-c-builds-cherry-picks branch January 6, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netbe netbe netbe approved these changes

@caldrian caldrian caldrian approved these changes

Assignees

@KaterinaWire KaterinaWire

Labels

echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaterinaWire @netbe @caldrian