chore: Adding QA automation to iOS repo - WPB-15067#2320
Merged
araneforseti merged 16 commits intodevelopfrom Jan 15, 2025
Merged
chore: Adding QA automation to iOS repo - WPB-15067#2320araneforseti merged 16 commits intodevelopfrom
araneforseti merged 16 commits intodevelopfrom
Conversation
araneforseti
requested review from
a team,
El-Fitz,
jullianm,
mythsunwind and
netbe
and removed request for
a team
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 73f42a5. ♻️ This comment has been updated with latest results. |
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
from
399ac3c to
a5d2ddf
Compare
mythsunwind
suggested changes
Jan 7, 2025
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
9 times, most recently
from
9d25c4c to
ad2b546
Compare
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
from
ad2b546 to
c7c6515
Compare
mythsunwind
suggested changes
Jan 13, 2025
Contributor
mythsunwind
left a comment
mythsunwind
left a comment
There was a problem hiding this comment.
I think the whole tools/img/osx directory can be deleted
netbe
reviewed
Jan 14, 2025
netbe
reviewed
Jan 15, 2025
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
Difficult to be exhaustive as the PR is large and not all my field, I've left some comments though
Contributor
Author
Yeah, I'm also getting Sven to review to make sure we get that part covered |
mythsunwind
approved these changes
Jan 15, 2025
Contributor
mythsunwind
left a comment
mythsunwind
left a comment
There was a problem hiding this comment.
LGTM. Let's get this merged 😃
netbe
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
To have the tests live with the code they are testing, we are moving the iOS automation tests out of the central QA repo and into the iOS repo
Testing
Automation running with this branch is viewable in the New Smoke job on Jenkins.
It should also be runable locally after going through all the setup
Checklist
[WPB-XXX].UI accessibility checklist
No UI changes