Skip to content

fix: Never ending syncing when MLS feature is enabled - WPB-15026#2329

Merged
KaterinaWire merged 13 commits intorelease/cycle-3.115from
fix/never-ending-syncing-2
Jan 2, 2025
Merged

fix: Never ending syncing when MLS feature is enabled - WPB-15026#2329
KaterinaWire merged 13 commits intorelease/cycle-3.115from
fix/never-ending-syncing-2

Conversation

@KaterinaWire
Copy link
Copy Markdown
Contributor

@KaterinaWire KaterinaWire commented Dec 23, 2024 •
edited
Loading

BugWPB-15026 [iOS] Never ending syncing when MLS feature is enabled

Issue

Never ending syncing when MLS feature is enabled.

Solution

The solution is to create the MLS client after saving the feature config change to the db. To achieve this:

  • there is a MLSFeatureProcessor for processing MLS feature.
  • MLSClientSyncManager to initiate the MLS client.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq Bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 23, 2024 •
edited
Loading

Test Results

    7 files      8 suites   10m 33s ⏱️
6 941 tests 6 912 ✅ 28 💤 1 ❌
6 951 runs  6 923 ✅ 28 💤 0 ❌

For more details on these failures, see this check.

Results for commit b12fc69.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Dec 23, 2024 •
edited
Loading

Datadog Report

Branch report: fix/never-ending-syncing-2
Commit report: cfcf074
Test service: wire-ios-mono

✅ 0 Failed, 6641 Passed, 28 Skipped, 4m 52.37s Total Time

@KaterinaWire KaterinaWire marked this pull request as ready for review December 27, 2024 15:01
johnxnguyen
johnxnguyen reviewed Dec 27, 2024
View reviewed changes
Comment thread wire-ios-data-model/Source/MLS/MLSClientSyncManager.swift Outdated
Comment thread wire-ios-data-model/Source/MLS/MLSClientSyncManager.swift Outdated
Comment thread wire-ios-data-model/Source/MLS/MLSClientSyncManager.swift Outdated
Comment thread wire-ios-data-model/Source/MLS/MLSClientSyncManager.swift Outdated
Comment thread ...strategy/Sources/Request Strategies/Feature configurations/Payload/MLSFeatureProcessor.swift Outdated
Comment thread wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift
@KaterinaWire KaterinaWire changed the base branch from develop to release/cycle-3.115 December 30, 2024 09:19
@echoes-hq echoes-hq Bot added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: unplanned/support Work items completed to meet a customer or user support request. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes/initiative: personal-users-to-team-users... echoes/initiative: ios-sync-refactoring labels Dec 30, 2024
@KaterinaWire KaterinaWire changed the base branch from release/cycle-3.115 to develop December 30, 2024 09:19
@KaterinaWire KaterinaWire mentioned this pull request Dec 30, 2024
Closed
6 tasks
@KaterinaWire KaterinaWire added DO NOT MERGE and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: personal-users-to-team-users... echoes: unplanned/support Work items completed to meet a customer or user support request. echoes/initiative: ios-sync-refactoring echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. labels Dec 30, 2024
johnxnguyen
johnxnguyen approved these changes Jan 2, 2025
View reviewed changes
Comment thread wire-ios-data-model/Source/MLS/MLSClientManager.swift Outdated
@KaterinaWire KaterinaWire force-pushed the fix/never-ending-syncing-2 branch from 8be98c4 to afd9aba Compare January 2, 2025 09:47
@KaterinaWire KaterinaWire changed the base branch from develop to release/cycle-3.115 January 2, 2025 09:48
@KaterinaWire KaterinaWire requested a review from caldrian January 2, 2025 10:08
@KaterinaWire KaterinaWire merged commit 09ddf6a into release/cycle-3.115 Jan 2, 2025
@KaterinaWire KaterinaWire deleted the fix/never-ending-syncing-2 branch January 2, 2025 13:22
zenkins pushed a commit that referenced this pull request Jan 2, 2025
@KaterinaWire @johnxnguyen @github-actions
fix: Never ending syncing when MLS feature is enabled - WPB-15026 (#2329
1df1343 
)

Co-authored-by: John Nguyen <28632506+johnxnguyen@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jan 2, 2025
Merged
6 tasks
@echoes-hq echoes-hq Bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caldrian caldrian caldrian approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

Assignees

@KaterinaWire KaterinaWire

Labels

echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaterinaWire @caldrian @johnxnguyen