Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inject self profile views monitor - WPB-15038 #2348

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: inject self profile views monitor - WPB-15038 #2348

merged 2 commits into from
Jan 7, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2025

This PR was automatically cherry-picked based on the following PR:

Original PR description:

Issue

The SelfProfileViewsMonitor is now injected, and a mock has been provided for testing purposes.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@github-actions github-actions bot added cherry-pick echoes/initiative: personal-users-to-team-users... echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: unplanned/support Work items completed to meet a customer or user support request. labels Jan 6, 2025
@netbe netbe requested a review from El-Fitz January 7, 2025 07:41
netbe
netbe approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no conflicts, good to be merged, but I left a question for understanding

...os/Wire-iOS Tests/ConversationList/Container/MockSelfProfileViewsMonitorImplementation.swift Show resolved Hide resolved
@El-Fitz El-Fitz force-pushed the feat/inject-self-profile-views-monitor-cherry-pick branch from 136aa64 to c1d6a98 Compare January 7, 2025 15:02
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jan 7, 2025 •
edited
Loading

Test Results

    1 files      2 suites   2m 4s ⏱️
1 789 tests 1 763 ✅ 26 💤 0 ❌
1 799 runs  1 773 ✅ 26 💤 0 ❌

Results for commit b88a569.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 7, 2025 •
edited
Loading

Datadog Report

Branch report: feat/inject-self-profile-views-monitor-cherry-pick
Commit report: d5a00f6
Test service: wire-ios-mono

✅ 0 Failed, 1685 Passed, 26 Skipped, 2m 4.49s Total Time

@El-Fitz El-Fitz enabled auto-merge January 7, 2025 15:45
@El-Fitz El-Fitz added this pull request to the merge queue Jan 7, 2025
Merged via the queue into develop with commit 663490a Jan 7, 2025
13 checks passed
@El-Fitz El-Fitz deleted the feat/inject-self-profile-views-monitor-cherry-pick branch January 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@El-Fitz El-Fitz El-Fitz approved these changes

@samwyndham samwyndham samwyndham approved these changes

@netbe netbe netbe approved these changes

Assignees

@El-Fitz El-Fitz

Labels
cherry-pick echoes/initiative: personal-users-to-team-users... echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned/support Work items completed to meet a customer or user support request. echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netbe @samwyndham @El-Fitz