chore: offload conversation calculation - WPB-17293#2921
Merged
dmitrysimkin merged 34 commits intodevelopfrom May 6, 2025
Merged
chore: offload conversation calculation - WPB-17293#2921dmitrysimkin merged 34 commits intodevelopfrom
dmitrysimkin merged 34 commits intodevelopfrom
Conversation
dmitrysimkin
commented
Apr 21, 2025
samwyndham
requested changes
Apr 24, 2025
# Conflicts: # wire-ios/Wire-iOS Tests/ConversationViewControllerSnapshotTests.swift
samwyndham
requested changes
Apr 28, 2025
johnxnguyen
reviewed
Apr 29, 2025
samwyndham
approved these changes
May 5, 2025
Contributor
samwyndham
left a comment
There was a problem hiding this comment.
Apologies @dmitrysimkin for the slow review of this. Well done for fighting with this screen. To be honest this screen deserves a complete rewrite as I believe the current way it is implemented is fundamentally flawed.
johnxnguyen
approved these changes
May 6, 2025
auto-merge was automatically disabled
May 6, 2025 13:08
Pull Request is not mergeable
6 tasks
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Attempt to improve conversation screen performance issues
What was done:
selfUserand messages back tosection controllersectionControllersandactionControllersthread safe dictionary to synchronise access from 2 threadsnonPersistenceObjectIdentifieras It does not fit environment with 2 threads, it gives different IDs in different threads.Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: