gundeck: Allow temporary recipients to receive events even when the u…

…ser doesn't have any regular RabbitMQ clients

integration/test/Test/Events.hs

@@ -90,6 +90,22 @@ testConsumeTempEvents = do
 
     assertNoEvent_ ws
 
+testConsumeTempEventsWithoutOwnClient :: (HasCallStack) => App ()
+testConsumeTempEventsWithoutOwnClient = do
+  [alice, bob] <- createAndConnectUsers [OwnDomain, OwnDomain]
+
+  runCodensity (createEventsWebSocket alice Nothing) $ \ws -> do
+    handle <- randomHandle
+    putHandle bob handle >>= assertSuccess
+
+    void $ assertEvent ws $ \e -> do
+      e %. "type" `shouldMatch` "event"
+      e %. "data.event.payload.0.type" `shouldMatch` "user.update"
+      e %. "data.event.payload.0.user.id" `shouldMatch` objId bob
+      e %. "data.event.payload.0.user.handle" `shouldMatch` handle
+
+      ackEvent ws e
+
 testMLSTempEvents :: (HasCallStack) => App ()
 testMLSTempEvents = do
   [alice, bob] <- createAndConnectUsers [OwnDomain, OwnDomain]

services/gundeck/src/Gundeck/Push.hs

@@ -185,7 +185,11 @@ splitPush clientsFull p = do
           -- Checking for rabbitmqClientIds first ensures that we fall back to
           -- old behaviour even if legacyClientIds is empty too. This way we
           -- won't break things before clients are ready for it.
-          (That rcpt)
+          --
+          -- We return all clients for RabbitMQ even if there are no real
+          -- clients so a temporary client can still read the notifications on
+          -- RabbitMQ.
+          (These rcpt {_recipientClients = RecipientClientsAll} rcpt)
         (_, []) ->
           (This rcpt)
         (r : rs, l : ls) ->