[WPB-15151] eliminate legahold test redundancy #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-15151-eliminate-lh-tests-redundancy
branch
from
3ff6ea0 to
aa7cfa2
Compare
supersven
requested changes
Dec 23, 2024
| -- | ||
| -- This flag allows to make tests run through both configurations with minimal adjustment. | ||
| data ImplicitConsent = ImplicitConsent | ExplicitConsent | ||
| deriving (Eq, Show, Generic) |
There was a problem hiding this comment.
Where does this need Generic? 🤔
There was a problem hiding this comment.
for the test collection machinery
integration/test/Test/LegalHold.hs
Outdated
| setLHFeatureConfigForServer ImplicitConsent app = | ||
| -- we could do `setField "settings.featureFlags.legalhold" | ||
| -- "whitelist-teams-and-implicit-consent"`, but this is already the default. | ||
| -- TODO: make this an assertion, not a comment! |
There was a problem hiding this comment.
Can't this easily be done now?
There was a problem hiding this comment.
right. missed that spot, thanks!
Co-authored-by: Sven Tennie <[email protected]>
... to guard against accidental change.
|
thanks, sven! the CI failures in 64193e7 seem unrelated? |
More ❄️ 😬 |
supersven
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d