Add multi-ingress domains to SCIM IdPs #4778
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersven
force-pushed
the
sventennie/scim-idp-with-domain
branch
from
5b2b73f to
559a318
Compare
zebot
added
the
ok-to-test
supersven
changed the title
We have to set some constraints on this field that wouldn't fit in the general case.
This should be up-to-date with what the migrations create.
supersven
force-pushed
the
sventennie/scim-idp-with-domain
branch
from
6a8da79 to
c2457d1
Compare
|
Hey @fisx 👋 May I ask you to review this? This PR touches sensitive areas and you surely have most knowledge/context here... |
fisx
reviewed
Sep 25, 2025
| in later lookups, at most one IdP can be configured per multi-ingress domain. | ||
| If multi-ingress is not configured or it's not configured for the specific | ||
| domain, no `domain` field gets added to the IdP. This guards against creating | ||
| multiple IdPs and then assigning them to multi-ingress domains. Thus, users who |
There was a problem hiding this comment.
you mean "guards against a team having no multi-ingress, but several idps that are only distinguished by domain (because domain is part of the database key)?
we do allow several idps per team, though, right? except there is some complication with scim and saml, and associating the two for one ipd, not sure what the current implementation status there is.
not sure this makes sense, but i'll leave it as a note to self so i can clarify later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://wearezeta.atlassian.net/browse/WPB-20052
Checklist
changelog.d