-
Notifications
You must be signed in to change notification settings - Fork 334
WPB-20214: Add member searchability #4786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
bc31287
to
78ad65e
Compare
The below is now resolved. The current error when running the test is this:
From running this command: |
9891c56
to
6a1a1b8
Compare
- make `!!!` definition easier to understand - extract `getProfile`
6a1a1b8
to
4790b05
Compare
@akshaymankar Noting here what you asked about in the standup: the When we had all data in postgres though, the query could entirely be done on the database side: join |
@eyeinsky I think we shouldn't support this query param on |
Task checklist:
searchable
/users/:uid/searchable
API endpoint and by team admin, and nowhere elseSetMemberSearchable
/search/contacts
must filter based on searchable = True/teams/:tid/members
must expose a filter to find non-searchable users; otherwise ignore itsearchable
field behaviorOpen questions
POST /users/:uid/searchable
, but as TeamId is required, then it currently isPOST /users/:uid/:tid/searchable
-- could this be improved?POST /handles
: should this endpoint also filter based on searchability?/search/contacts
to take searchability into account?Checklist
changelog.d