-
Notifications
You must be signed in to change notification settings - Fork 334
WPB-20209 forward ip address of the remote from federator to component reapply #4805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
WPB-20209 forward ip address of the remote from federator to component reapply #4805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements IP address forwarding from federator to backend components for federation requests. It extracts the remote peer IP address during federation communication and forwards it to upstream services for audit logging purposes.
- Enhances federator to capture and forward remote IP addresses from federation connections
- Updates cargohold's asset audit logging to include remote backend IP information
- Adds nginx configuration to properly forward IP headers to upstream services
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
services/federator/src/Federator/Remote.hs | Captures peer IP during HTTP2 connections and adds it to response headers |
services/federator/src/Federator/ExternalServer.hs | Extracts and forwards origin IP from request headers to upstream services |
libs/wire-api-federation/src/Wire/API/Federation/Endpoint.hs | Adds new header types and streaming endpoint with remote IP support |
services/cargohold/src/CargoHold/API/AuditLog.hs | Updates audit logging functions to include optional IP address parameter |
services/cargohold/src/CargoHold/API/Federation.hs | Modifies federation endpoints to handle and pass remote IP for audit logging |
services/nginz/integration-test/conf/nginz/nginx.conf | Adds IP normalization and forwarding configuration for test environment |
charts/nginz/templates/conf/_nginx.conf.tpl | Updates production nginx config to forward IP headers to upstreams |
Comments suppressed due to low confidence (1)
services/federator/src/Federator/Remote.hs:1
- The
isDigit
function is not in scope. You need to importData.Char (isDigit)
or useData.Char.isDigit
.
{-# LANGUAGE RecordWildCards #-}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Checklist
changelog.d