LG-73 Partial CDD API support #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgunes-wirepas
commented
Feb 21, 2025
sgunes-wirepas
force-pushed
the
feature/LG-73-cdd_api_part1
branch
2 times, most recently
from
23a4d24 to
452cf7d
Compare
Includes support for the following: - Setting an item (WPC_set_config_data_item) - Getting an item (WPC_get_config_data_item) - Registering a callback for an item indication (WPC_register_for_config_data_item)
sgunes-wirepas
force-pushed
the
feature/LG-73-cdd_api_part1
branch
from
452cf7d to
2a87546
Compare
| * \brief Register for receiving config data item | ||
| * \param onConfigDataItemReceived | ||
| * The callback to call when config data item is received | ||
| * \note All the registered callback share the same thread, |
There was a problem hiding this comment.
Can you register to it if you are a sink?
Question is more to know if a CDD can be written by the stack itself so the sink app can also be informed this way that something has changed.
| // Response | ||
| sap_resp_pl_t sap_response_payload; | ||
| } payload; | ||
| } wpc_frame_t; | ||
|
|
||
| // Make sure each member of the payload union has a size representable by the | ||
| // payload_length field | ||
| _Static_assert(sizeof(((wpc_frame_t*)0)->payload) <= UINT8_MAX, ""); |
|
|
||
| wpc_frame_t request = { | ||
| .primitive_id = MSAP_CONFIG_DATA_ITEM_SET_REQUEST, | ||
| .payload_length = sizeof(msap_config_data_item_set_req_pl_t), |
There was a problem hiding this comment.
So even if CDD is 10 bytes, 80 bytes are sent? (padded with 00)
I guess you did it this way as it was the expectation on dualmcu app side.
I guess it is like this to mimic the old implementation of app_config :-)
GwendalRaoul
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support for the following: