[Feature]: Accessibility upgrade #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickBanken
changed the title
Tanya-Amber-L
approved these changes
Jan 27, 2025
| ```vue | ||
| <button aria-label="Close">X</button> | ||
| ``` | ||
| - **Provide Text Alternatives**: Use alt attributes for images and other non-text content. This helps screen readers provide a description of images, icons, and other visual elements. |
There was a problem hiding this comment.
I like this ressource for alternative text best practices, maybe we can add it?
https://web.dev/learn/accessibility/images#alternative_text_best_practices
| - Follow WCAG Guidelines: Adhere to the Web Content Accessibility Guidelines (WCAG), which recommend a minimum contrast ratio of: | ||
| - 4.5:1 for normal text (under 18px or bold text under 14px). | ||
| - 3:1 for large text (18px or larger, or bold text 14px or larger). | ||
| - Use Contrast Checking Tools: Tools like `WebAIM's` Contrast Checker or browser plugins can help you validate contrast ratios. |
There was a problem hiding this comment.
When you mention a specific tool, can you maybe add a link to the tool's website?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.