[Chore] Accessibility fixes #111
Conversation
Tanya-Amber-L
requested review from
NickBanken,
JeffreyNijs,
maltsavkiryl,
JeroenVanC,
Robbe95 and
wouterlms
as code owners
| @@ -129,7 +129,7 @@ | |||
| --text-tertiary: var(--gray-400); | |||
| --text-tertiary-hover: var(--gray-300); | |||
| --text-tertiary-on-brand: var(--gray-400); | |||
| --text-quaternary: var(--gray-400); | |||
| --text-quaternary: var(--gray-500); | |||
There was a problem hiding this comment.
@wouterlms is het de bedoeling dat deze aangepast wordt van 400 naar 500?
There was a problem hiding this comment.
Uh, van waar komt deze change @Tanya-Amber-L ?
There was a problem hiding this comment.
This is for contrast reasons, else the a11y report fails. Needs to stay.
Plus, gray-400 is already used for text-tertiary
There was a problem hiding this comment.
moet je dat niet de waarde aanpassen van gray-400?
There was a problem hiding this comment.
Instead of changing every place where gray-400 was used, i decided to change text-quaternary. Because it made ore sense to me rather than keep text-tertiary AND text-quaternary to both point to gray-400
There was a problem hiding this comment.
Hmm, I copied this from untitled so maybe we need to check if I copied it correctly and if not, fix it indeed. But if it is correct then we need to see where the issue is
Context
Update formango version
Uncomment and use the playwright's AxeBuilder
Add tests for settings>roles module
Fix few accessibility errors
Description
(Not ready to merge, because failing tests, before vue-core v2 is also updated with a11y fixes)
Checklist
Screenshots (optional)