Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Output #98

wants to merge 1 commit into from

Conversation

xkxx
Copy link
Contributor

@xkxx xkxx commented May 8, 2014

I would like to add an --output flag to the compiler along with the ability to compile multiple files at once, for the following reasons:

  • Familiarity. Most compilers I've seen have this option. It's natural to try to use -o for outputting files. coffee-script, rustc, gcc, nimrod, javac, to list some examples
  • Ease of use inside terminal. Say you are just wanting to compile a three odd files and don't want to use a build system yet. wisp a.wisp b.wisp c.wisp -o ./ is a lot easier to type than repeatedly pushing the up arrow to retrieve the last three commands
  • Simplicity It's a lot less likely to make typos like " > test.jjs" if the compiler handles it
  • CoffeeScriptRedux does have a output flag https://github.com/michaelficarra/CoffeeScriptRedux/blob/master/src/cli.coffee#L148
  • It does not really add much code to the compiler, just 12 lines.

@davidchambers
Copy link

Thanks for correcting my error, @xkxx. I misremembered a discussion. The thing CSR does not do is create directories: -o does/not/exist results in an error.

@Gozala
Copy link
Collaborator

Gozala commented May 8, 2014

Fine by me, but this is no longer up to date as I had to fix regressions introduced by #97

Also --print flag and --output flags are incompatible and should not be allowed together as writing AST into .js file does not makes much sense to me.

@xkxx
Copy link
Contributor Author

xkxx commented May 9, 2014

I've merged upstream changes. There seems to be a problem with --print handling that appends the input by "code". Removing str fixes the problem. The merge log looks very messy, though, for some reason.

@Gozala
Copy link
Collaborator

Gozala commented May 12, 2014

I am afraid this still appears as "We can’t automatically merge this pull request." so probably there is merge conflict that needs to be resolved. I'd say you need to merge with upstream as I don't see such a commit here that's what I think is causes issues.

@xkxx
Copy link
Contributor Author

xkxx commented May 12, 2014

Hum, that's weird. I will open a fresh fork and see if that fixes it.

@xkxx
Copy link
Contributor Author

xkxx commented May 12, 2014

How about now?

@Gozala
Copy link
Collaborator

Gozala commented May 12, 2014

Now it looks mergable, but I would like to test this time around to make sure nothing breaks. I'll merge once I'll run tests ;)

Thanks

@Gozala Gozala closed this May 12, 2014
@Gozala Gozala reopened this May 12, 2014
@Gozala
Copy link
Collaborator

Gozala commented Jun 1, 2015

@xkxx I appologise this project has definitely went undermaintained for quite some time now. I beleive I'm back on track now, I'll try to respond with any open issues with in the week & go through all open pulls (including this one) this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants