Skip to content

Conversation

jp-knj
Copy link
Contributor

@jp-knj jp-knj commented May 3, 2025

Summary

Adds first-class Deno support to withastro/action, enabling projects that
use deno.json / deno.lock to run deno task build out-of-the-box.

Changes

  • Detects deno.json(c) or deno.lock; sets PACKAGE_MANAGER=deno
  • New deno-version input (default 1.x)
  • Installs Deno via denoland/setup-deno@v2
  • Skips Node setup when PACKAGE_MANAGER=deno
  • Separate install/build steps for Deno

Related issue / discussion

Closes #65 (good first issue: Deno support)

Test plan

  1. Local smoke test
   pnpm build && act -j test-deno

Ref

@jp-knj jp-knj changed the title feat: add deno support Support Deno May 3, 2025
@jp-knj jp-knj mentioned this pull request May 3, 2025
@jp-knj jp-knj marked this pull request as ready for review May 3, 2025 13:22
@jp-knj
Copy link
Contributor Author

jp-knj commented May 30, 2025

@Fryuni

update documentation, good enough? or add documentation in this repo?
withastro/github-pages#8

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jp-knj! Sorry we dropped the ball on this — just saw it now while looking through the open PRs. I had a few questions about the approach.

- deno now follows the same pattern as npm/yarn/pnpm/bun
- unified install step handles all package managers
- support npm dependencies in hybrid Deno projects via deno install
- use package-manager input for Deno version (e.g., [email protected])
@jp-knj
Copy link
Contributor Author

jp-knj commented Sep 1, 2025

@delucis, Thanks for spotting that!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @jp-knj!

jp-knj and others added 3 commits September 4, 2025 01:06
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this work @jp-knj!

@delucis delucis merged commit e8cea0c into withastro:main Sep 15, 2025
delucis added a commit that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno support
3 participants