feat(vercel): allow external redirects #404
Conversation
🦋 Changeset detectedLatest commit: 6c06aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -18,6 +18,7 @@ describe('Redirects', () => { | |||
| }, | |||
| '/blog/[...slug]': '/team/articles/[...slug]', | |||
| '/Basic/http-2-0.html': '/posts/http2', | |||
| '/google': 'https://google.com', | |||
There was a problem hiding this comment.
Astro doesn't support external redirects, so adding on here is misleading because it won't work with other adapters.
Since you're adding the feature for the Vercel adapter, what about adding a new option to the adapter, maybe called externalRedirects?
There was a problem hiding this comment.
Not officially, but I ran into this when switching out the Cloudflare adapter, where a redirect like the one in the test works. That is what prompted me to create this PR.
Otherwise, I would strongly welcome external redirects becoming officially supported, as this should only require small adjustments, and it feels like the most intuitive approach.
This PR was originally opened on the main Astro repo: withastro/astro#11422
Changes
Before:
Redirects with schema defined in astro.config.mjs were converted into paths on the same site: https://google.com -> /https://google.com
After:
External redirects are detected and don't have the project base path prepended.
Testing
The output (esp.
.vercel/output/config.json) of building a project with the updated integration was manually inspected.A test was added
Docs
The Astro docs generally state that supporting external links configured through
astro.config.mjsisn't a goal. While the Cloudflare adapter already supports external redirects, the Vercel adapter handled external redirects differently so far. Therefore this could potentially be considered a breaking change.