chore: improve support for Workers Assets beta

[alexanderniebuhr]

Changes

• this improves support for Workers Assets Beta, mainly getting rid of not needed Platform files and making sure the SSR bundle does not get exposed if called by the /_worker.js/index.js url.
• Workers Assets is still in beta, so this is also only Beta supported by us for now
• more info to find
  • https://developers.cloudflare.com/workers/static-assets/
  • https://developers.cloudflare.com/workers/frameworks/framework-guides/astro/
  • https://blog.cloudflare.com/builder-day-2024-announcements/
• it should get paired with the following minimal wrangler.toml (not sure how we can provide that to the user)

name = ""
compatibility_date = "2024-09-19"
main = "./dist/_worker.js/index.js"
assets = { directory = "./dist/assets", binding = "ASSETS" }

Testing

• not needed

Docs

• needs a docs PR, will prepare one

cc @dario-piotrowicz @petebacondarwin

[changeset-bot]

🦋 Changeset detected

Latest commit: 7d5d92a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@astrojs/cloudflare	Minor
@test/astro-cloudflare-astro-dev-platform	Patch
@test/astro-cloudflare-astro-env	Patch
@test/astro-cloudflare-compile-image-service	Patch
@test/astro-cloudflare-external-image-service	Patch
@test/astro-cloudflare-wasm	Patch
@test/astro-cloudflare-no-output	Patch
@test/astro-cloudflare-routes-json	Patch
@test/astro-cloudflare-with-solid-js	Patch
@test/astro-cloudflare-wrangler-preview-platform	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ematipico]

This PR seems to add a new option for the user. This means that this isn't a refactor, but a real minor that requires a changeset and new tests.

[alexanderniebuhr]

I agree with the changeset, however I'm not sure about the test, because this is still beta. So I don't want our tests to fail, just because Cloudflare changes something. I guess it would be better to have tests only added once it is stable in Cloudflare.

[ematipico]

I guess it would be better to have tests only added once it is stable in Cloudflare.

Can you explain why our tests would fail? I don't see any new dependency added, so I probably miss some context. Nonetheless, I trust your judgment.

If these workers assets are beta, I suppose that even out option should be experimental.

[alexanderniebuhr]

Fail is the wrong term here, sorry. I meant the tests would not represent the stable expectations anymore, if the platform assumptions change.

But I agree the flag should be experimental. I'll change the code.

[ematipico]

Left a couple of suggestions (nitpicks). We have some docs before shipping this, I suppose.

[ematipico]

nit: Regex created in a for loop are wasteful. They can be created in a top-level function and re-used

[alexanderniebuhr]

Good point, I'll address it in a follow up PR, since it was like this before.

[ematipico]

Same here

[alexanderniebuhr]

Good point, I'll address it in a follow up PR, since it was like this before.

[alexanderniebuhr]

Going to add some docs PR and going to address the nitpicks.

[alexanderniebuhr]

Going to add some docs PR and going to address the nitpicks.

[alexanderniebuhr]

Actually I think it is just easier for users to add a ignore file, so we don't need to support two different build outputs.. closing, still going to write docs PR to explain this to users.

https://developers.cloudflare.com/workers/static-assets/binding/#ignoring-assets