This repository has been archived by the owner on Feb 10, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a result of the discussion in withastro/astro#13167. I found a quick win that makes things a lot better without additional risk. More could be done to generate smaller, correct solutions for even more cases - but as a first step I'm pretty happy with this.
Problem: When there are a lot of static pages (resulting in more than 100 combined include/exclude entries, the adapter would generate a _routes.json with a
/*
include and a truncated array of excludes. Even if having a fewincludes
and noexcludes
instead would be a correct solution too - with the added benefit of no unnecessary function invocations.Solution: I improved the condition which switches between the two options (option 1 =
/*
include + many excludes; option 2 = many includes, fewer excludes). Now option 2 is chosen if: there is a static 404 AND option 2 is below the limit.Testing
I added two test cases with many static files. One with and one without a static 404 file.
Docs
Not sure if anything needs to be documented.