Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents access to the history state if not set #12436

Merged
merged 2 commits into from
Nov 15, 2024
Merged

prevents access to the history state if not set #12436

merged 2 commits into from
Nov 15, 2024

Conversation

martrapp
Copy link
Member

Changes

do not access properties of the browsers history state if it is not defined

Testing

defensive coding, no additional test

Docs

n.a.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: ed464bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 14, 2024
@martrapp
Copy link
Member Author

Fixes #12435

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #12436 will not alter performance

Comparing mt/npe (ed464bb) with main (e64ec5f)

Summary

✅ 6 untouched benchmarks

@bluwy bluwy linked an issue Nov 15, 2024 that may be closed by this pull request
1 task
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need a changeset?

@bluwy bluwy merged commit 453ec6b into main Nov 15, 2024
15 checks passed
@bluwy bluwy deleted the mt/npe branch November 15, 2024 08:09
@astrobot-houston astrobot-houston mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible null reference error
2 participants