Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publint checks #12445

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add publint checks #12445

merged 2 commits into from
Nov 15, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 15, 2024

Changes

Use publint to lint the publish code so that we catch package exports issues and missing published files. I've updated the package.jsons to resolve its suggestions/warnings/errors so it should now be clean.

Testing

Ran pnpm run publint at the root.

Docs

n/a

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #12445 will not alter performance

Comparing add-publint (a248e80) with main (8e135b6)

Summary

✅ 6 untouched benchmarks

@bluwy bluwy merged commit cec4af8 into main Nov 15, 2024
16 checks passed
@bluwy bluwy deleted the add-publint branch November 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @ematipico @florian-lefebvre