-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[v6] integration api cleanup #12445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6] integration api cleanup #12445
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (Reminder when I approve these to also then ping me later in the astro PR when you're doing the changeset!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, didn't notice the link check. and didn't see this was a draft anyway! Lots of stuff for me to fix here first! 😅
When links break in a previous upgrade guide, it's sufficient to keep that old text but just remove the link. The advice should stay as it was, relevant for that time. But now there's just no link for removed things.
I've removed broken links, but in the case of translated adapter-reference
files, there are entire sections that could be removed, as long as we are careful about matching sections. I suggest we do this before this PR is merged!
I think this should fix the last link! Then, LGTM! |
Tests are passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links are happy, I am happy!
Co-authored-by: Sarah Rainsberger [email protected]
Description (required)
Related issues & labels (optional)
For Astro version:
6.0
. See astro PR #14446.