Skip to content

Conversation

florian-lefebvre
Copy link
Member

Co-authored-by: Sarah Rainsberger [email protected]

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #14446.

Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit b8b9266
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68da7a7a44f1e50008ed3d2b
😎 Deploy Preview https://deploy-preview-12445--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 26, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
en/reference/adapter-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/integrations-reference.mdx Source changed, localizations will be marked as outdated.
es/guides/internationalization.mdx Localization changed, will be marked as complete.
es/reference/adapter-reference.mdx Localization changed, will be marked as complete.
ja/reference/adapter-reference.mdx Localization changed, will be marked as complete.
ko/guides/upgrade-to/v5.mdx Localization changed, will be marked as complete.
ko/reference/adapter-reference.mdx Localization changed, will be marked as complete.
ko/reference/integrations-reference.mdx Localization changed, will be marked as complete.
pt-br/reference/adapter-reference.mdx Localization changed, will be marked as complete.
zh-cn/guides/upgrade-to/v5.mdx Localization changed, will be marked as complete.
zh-cn/reference/adapter-reference.mdx Localization changed, will be marked as complete.
zh-cn/reference/integrations-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Reminder when I approve these to also then ping me later in the astro PR when you're doing the changeset!)

@sarah11918 sarah11918 self-requested a review September 26, 2025 16:51
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, didn't notice the link check. and didn't see this was a draft anyway! Lots of stuff for me to fix here first! 😅

When links break in a previous upgrade guide, it's sufficient to keep that old text but just remove the link. The advice should stay as it was, relevant for that time. But now there's just no link for removed things.

I've removed broken links, but in the case of translated adapter-reference files, there are entire sections that could be removed, as long as we are careful about matching sections. I suggest we do this before this PR is merged!

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 26, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review September 29, 2025 09:06
@sarah11918
Copy link
Member

I think this should fix the last link! Then, LGTM!

@florian-lefebvre
Copy link
Member Author

Tests are passing!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are happy, I am happy!

@florian-lefebvre florian-lefebvre merged commit 824ae0d into v6 Sep 29, 2025
11 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/integration-api-cleanup branch September 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0 i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants