Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added social icon for Nostr #2579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added social icon for Nostr #2579

wants to merge 1 commit into from

Conversation

RafidMuhymin
Copy link
Member

@RafidMuhymin RafidMuhymin commented Nov 6, 2024 •
edited
Loading

Description

  • Added social icon for Nostr.

Icon Reference: https://github.com/mbarulli/nostr-logo/blob/main/SVG/nostr-icon-purple-on-white.svg. I optimized the icon and made changes to align with the other social icons.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 6512289

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 6, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 6512289
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/672af7bf56798400087913e2
😎 Deploy Preview https://deploy-preview-2579--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

delucis
delucis reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @RafidMuhymin (and nice to see you 👋)!

Left two tiny superficial suggestions, but this all looks solid to me 🚀

packages/starlight/components/Icons.ts
@@ -158,6 +158,8 @@ export const BuiltInIcons = {
'<path d="M6.49 19.04h-.23L5.13 17.9v-.23l1.73-1.71h1.2l.15.15v1.2L6.5 19.04ZM5.13 6.31V6.1l1.13-1.13h.23L8.2 6.68v1.2l-.15.15h-1.2zm9.96 9.09h-1.65l-.14-.13v-3.83c0-.68-.27-1.2-1.1-1.23c-.42 0-.9 0-1.43.02l-.07.08v4.96l-.14.14H8.9l-.13-.14V8.73l.13-.14h3.7a2.6 2.6 0 0 1 2.61 2.6v4.08l-.13.14Zm-8.37-2.44H.14L0 12.82v-1.64l.14-.14h6.58l.14.14v1.64zm17.14 0h-6.58l-.14-.14v-1.64l.14-.14h6.58l.14.14v1.64zM11.05 6.55V1.64l.14-.14h1.65l.14.14v4.9l-.14.14h-1.65zm0 15.81v-4.9l.14-.14h1.65l.14.13v4.91l-.14.14h-1.65z"/>',
deno: '<path d="M12 0a12 12 0 1 1 0 24 12 12 0 0 1 0-24m-.47 6.8c-3.49 0-6.2 2.19-6.2 4.92 0 2.58 2.5 4.23 6.37 4.15h.12l.42-.02-.1.28v.03l.09.22v.03l.02.04.02.07.02.04.01.05.02.05.02.07.02.08.02.06.02.08.02.09.02.09.03.1.01.06.03.1.02.1.03.15.02.07.02.11.03.12.02.12.04.17.02.15.04.2.02.1.03.15.03.15.04.22.04.23.04.23.04.24.04.24.04.26.04.26.04.2.05.34.02.14.06.36.04.3.04.22.04.31.03.16a10.76 10.76 0 0 0 6.53-3.41l.05-.06-.24-.89-.64-2.37-.39-1.47-.35-1.3-.21-.78-.14-.5-.08-.3-.07-.26-.03-.11-.02-.07-.01-.03v-.03a6.04 6.04 0 0 0-2.05-2.97 6.75 6.75 0 0 0-4.25-1.35M8.47 19.3a.59.59 0 0 0-.72.4v.01l-.53 1.96q.5.24 1.01.43l.08.03.57-2.11V20a.59.59 0 0 0-.41-.7m3.26-1.43a.59.59 0 0 0-.71.4v.01l-.8 2.96v.01a.59.59 0 0 0 1.12.3l.8-2.96v-.02l.02-.06v-.02l-.02-.1-.02-.14-.02-.08a.58.58 0 0 0-.37-.3Zm-5.55-3.04a1 1 0 0 0-.04.09v.02l-.8 2.95v.02a.59.59 0 0 0 1.13.3v-.01l.72-2.68a5.3 5.3 0 0 1-1.01-.7Zm-1.9-3.4a.59.59 0 0 0-.72.4v.02l-.8 2.95v.01a.59.59 0 0 0 1.13.3l.8-2.96v-.01a.59.59 0 0 0-.41-.7m17.87-.68a.59.59 0 0 0-.72.4v.02l-.8 2.95v.01a.59.59 0 0 0 1.13.3l.8-2.96v-.01a.59.59 0 0 0-.41-.7M2.55 6.81a10.7 10.7 0 0 0-1.26 3.93.59.59 0 0 0 1-.22v-.02l.8-2.95v-.01a.59.59 0 0 0-.55-.73m17.59.02a.59.59 0 0 0-.72.4v.01l-.8 2.96v.01a.59.59 0 0 0 1.13.3l.8-2.96v-.01a.59.59 0 0 0-.41-.7Zm-7.85 1.93a.75.75 0 1 1 0 1.5.75.75 0 0 1 0-1.5M6.01 4.03a.59.59 0 0 0-.71.4v.02L4.5 7.4v.01a.59.59 0 0 0 1.12.3l.8-2.96v-.01a.59.59 0 0 0-.41-.7Zm10.24.56a.59.59 0 0 0-.71.4V5L15 7q.52.26.99.6l.05.04.62-2.32V5.3a.59.59 0 0 0-.41-.7m-5.21-3.34a11 11 0 0 0-1.12.16l-.07.01L9.1 4.2v.01a.59.59 0 0 0 1.13.3l.8-2.96v-.01a.6.6 0 0 0 0-.27m7.34 2.04-.16.58v.02a.59.59 0 0 0 1.13.3V4.2l.02-.07a11 11 0 0 0-.92-.77zm-4.64-1.94-.28 1.05a.59.59 0 0 0 1.13.31v-.01l.3-1.1q-.52-.15-1.06-.24z"/>',
jsr: '<path d="M3.7 5.54v3.7H0v7.38h7.38v1.84h12.93v-3.7H24V7.39h-7.38V5.54Zm1.84 1.85h1.85v7.38H1.84v-3.7h1.84v1.85h1.85zm3.7 0h5.53v1.84h-3.7v1.85h3.7v5.53H9.23v-1.84h3.7v-1.85h-3.7Zm7.38 1.84h5.53v3.7h-1.84v-1.85h-1.85v5.54h-1.84z"/>',
nostr:
'<path fill="none" d="M-24.83-25.1h256v256h-256z"/><path d="M21.633 10.597v9.68a.66.66 0 0 1-.66.66H13.06a.66.66 0 0 1-.66-.66v-1.802c.037-2.21.27-4.327.761-5.29.295-.58.78-.895 1.337-1.063 1.052-.317 2.9-.1 3.684-.138 0 0 2.368.095 2.368-1.247 0-1.08-1.059-.994-1.059-.994-1.166.03-2.055-.049-2.63-.276-.965-.379-.998-1.075-1.001-1.307-.048-2.687-4.01-3.01-7.5-2.343-3.817.726.042 6.196.042 13.499v.975a.658.658 0 0 1-.658.647H3.825a.66.66 0 0 1-.66-.659V3.535a.66.66 0 0 1 .66-.66h3.683a.66.66 0 0 1 .66.66c0 .54.608.842 1.048.527 1.325-.95 3.025-1.455 4.928-1.455 4.263 0 7.487 2.484 7.487 7.99zm-7.077-1.965a1.41 1.41 0 1 0-2.822 0 1.41 1.41 0 0 0 2.822 0z"/>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this through SVGOMG and removed the invisible first path to reduce the size slightly:

Suggested change
'<path fill="none" d="M-24.83-25.1h256v256h-256z"/><path d="M21.633 10.597v9.68a.66.66 0 0 1-.66.66H13.06a.66.66 0 0 1-.66-.66v-1.802c.037-2.21.27-4.327.761-5.29.295-.58.78-.895 1.337-1.063 1.052-.317 2.9-.1 3.684-.138 0 0 2.368.095 2.368-1.247 0-1.08-1.059-.994-1.059-.994-1.166.03-2.055-.049-2.63-.276-.965-.379-.998-1.075-1.001-1.307-.048-2.687-4.01-3.01-7.5-2.343-3.817.726.042 6.196.042 13.499v.975a.658.658 0 0 1-.658.647H3.825a.66.66 0 0 1-.66-.659V3.535a.66.66 0 0 1 .66-.66h3.683a.66.66 0 0 1 .66.66c0 .54.608.842 1.048.527 1.325-.95 3.025-1.455 4.928-1.455 4.263 0 7.487 2.484 7.487 7.99zm-7.077-1.965a1.41 1.41 0 1 0-2.822 0 1.41 1.41 0 0 0 2.822 0z"/>',
'<path d="M21.6 10.6v9.7a.7.7 0 0 1-.6.6h-8a.7.7 0 0 1-.6-.6v-1.8c0-2.2.3-4.4.8-5.3a2 2 0 0 1 1.3-1c1-.4 2.9-.2 3.7-.2 0 0 2.3 0 2.3-1.3 0-1-1-1-1-1-1.2 0-2 0-2.6-.2-1-.4-1-1.1-1-1.3 0-2.7-4-3-7.5-2.4-3.9.7 0 6.2 0 13.5v1a.7.7 0 0 1-.7.6H3.8a.7.7 0 0 1-.6-.6V3.5a.7.7 0 0 1 .6-.6h3.7a.7.7 0 0 1 .7.6c0 .6.6.9 1 .6 1.3-1 3-1.5 5-1.5 4.2 0 7.4 2.5 7.4 8zm-7-2a1.4 1.4 0 1 0-2.9 0 1.4 1.4 0 0 0 2.9 0z"/>',

.changeset/calm-worms-count.md
'@astrojs/starlight': patch
---

Added social icon for Nostr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit, but we usually use “adds” rather than “added” in our changelogs (see our changeset docs):

Suggested change
Added social icon for Nostr
Adds social link icon for Nostr

@delucis delucis added the 🌟 patch Change that triggers a patch release label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafidMuhymin @astrobot-houston @delucis