Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] Update starlight-links-validator and fix link #2598

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 10, 2024

Description

While working on #2578, I made a patch update to starlight-links-validator to simplify some legacy internal types and avoid future type errors. While testing it, I noticed a link issue.

This PR updates the starlight-links-validator package to the latest version and looks like the new errorOnLocalLinks option I added mostly for myself found an issue in one of our documentation pages.

Copy link

changeset-bot bot commented Nov 10, 2024

⚠️ No Changeset found

Latest commit: 3beae28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3beae28
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6730c98329aec40008ed0be5
😎 Deploy Preview https://deploy-preview-2598--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Nov 10, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
pt-br reference/configuration.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@HiDeoo HiDeoo marked this pull request as draft November 10, 2024 14:28
@HiDeoo HiDeoo changed the title Update starlight-links-validator and fix link [i18nIgnore] Update starlight-links-validator and fix link Nov 10, 2024
@HiDeoo HiDeoo marked this pull request as ready for review November 10, 2024 14:59
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, that’s a good link to sneak through! 😀

Awesome stuff — thanks for the updated version and the fix @HiDeoo 💖

@delucis delucis merged commit a4a9667 into withastro:main Nov 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants