feat: implement textDocument/formatting#401
Open
steeve wants to merge 1 commit intowithered-magic:mainfrom
Open
feat: implement textDocument/formatting#401steeve wants to merge 1 commit intowithered-magic:mainfrom
steeve wants to merge 1 commit intowithered-magic:mainfrom
Conversation
steeve
force-pushed
the
steeve/formatting
branch
2 times, most recently
from
3bd5630 to
d7e75f4
Compare
steeve
force-pushed
the
steeve/formatting
branch
from
d7e75f4 to
7ee86d2
Compare
This is done by spawning a `buildifier` process.
Buildifier can be configured in the initialization options:
```json
{
"buildifier": {
"path": "...",
"args": ["...", "..."]
}
}
```
Closes withered-magic#267
steeve
force-pushed
the
steeve/formatting
branch
from
7ee86d2 to
2d7da47
Compare
Author
|
Gentle ping @withered-magic :) |
Owner
|
sorry for late movement here, I'll try to get this in soon! |
Author
|
gentle ping ! |
Owner
|
Sorry, forgot to reply here! Can we gate this behind a flag, e.g. |
Author
|
sure! |
Owner
|
great! lmk if you'd like me to make that change too and then I can just merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done by spawning a
buildifierprocess.Buildifier can be configured in the initialization options:
{ "buildifier": { "path": "...", "args": ["...", "...."] } }Closes #267
PS: note that this was done at 99% by Gemini Pro 2.5