Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Node] Add .cjs extension to filepaths suggestions #2263

Closed
wants to merge 0 commits into from
Closed

[Node] Add .cjs extension to filepaths suggestions #2263

wants to merge 0 commits into from

Conversation

yaronuliel
Copy link
Contributor

Resolving #2262

@withfig-bot
Copy link
Collaborator

withfig-bot commented Feb 6, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

withfig-bot commented Feb 6, 2024 •
edited
Loading

No files changed ☑️

@withfig-bot
Copy link
Collaborator

Hello @yaronuliel,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@grant0417
Copy link
Member

Hey @yaronuliel can you sign the CLA?

@yaronuliel
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yaronuliel yaronuliel closed this Feb 7, 2024
@withfig withfig locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grant0417 grant0417 Awaiting requested review from grant0417

@mschrage mschrage Awaiting requested review from mschrage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yaronuliel @withfig-bot @grant0417