Fixing wpf v3 #67
Open
Fixing wpf v3 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Oct 21, 2025
| reverse: options?.reverse | ||
| limit: options?.limit || 1, | ||
| offset: options?.offset || 0, | ||
| reverse: options?.reverse || true |
There was a problem hiding this comment.
If we use reverse = false, then false || true is always true so reverse can't never be false. We have to check if it's false instead of undefined
|
|
||
| promisePoller({ | ||
| taskFn: () => this.provider.getTransaction(hash), | ||
| taskFn: () => this.provider.getTransaction(hash).catch(err => err), |
There was a problem hiding this comment.
What is the expected behavior here? if we use .catch(e=>e) we will always return a value instead of handling the error. Example here
There was a problem hiding this comment.
Apparently, promisePoller is not catching eventual exceptions when executing taskFn(), so instead of passing the Exception as an error value to shouldContinue, it was bubbling up the exception and therefore unexpectedly exiting from the "confirmTransaction" workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.