-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CVE-2024-21538 by migrating to promisify-child-process #4658
base: master
Are you sure you want to change the base?
Conversation
I haven't personally tested the changes yet, so let's rely on the CI/CD workflows to validate them. |
Kudos, @matinzd! We'll check the PR on Monday, I'll start the review today. |
Thanks @noomorph! Can you maybe approve the workflow runs to see how it goes? |
@matinzd please revert xcode changes first. 🙏 |
Done! |
I guess I need to fix some stuff. I will do it tomorrow. |
Made updates and resolved some test failures, though a few tests are still failing. Please feel free to push to my branch or advise on necessary changes. |
It would be really nice to have this one fixed |
Well, the drop-in replacement does not fit as advertised. I need to find a bit more time to fix the remainder. 🤷♂️ |
Ok - that was also what I concluded when I had a look at it |
Description
Detox is using a vulnerable package described in CVE-2024-21538.
In this pull request, I have migrated away from unmaintained
child-promise-process
topromisify-child-process
to fix the transitive vulnerability oncross-spawn
package.