Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2024-21538 by migrating to promisify-child-process #4658

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

matinzd
Copy link
Contributor

@matinzd matinzd commented Dec 13, 2024

Description

Detox is using a vulnerable package described in CVE-2024-21538.

In this pull request, I have migrated away from unmaintained child-promise-process to promisify-child-process to fix the transitive vulnerability on cross-spawn package.


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@matinzd
Copy link
Contributor Author

matinzd commented Dec 13, 2024

I haven't personally tested the changes yet, so let's rely on the CI/CD workflows to validate them.

@noomorph
Copy link
Collaborator

Kudos, @matinzd!

We'll check the PR on Monday, I'll start the review today.

@matinzd
Copy link
Contributor Author

matinzd commented Dec 13, 2024

Thanks @noomorph! Can you maybe approve the workflow runs to see how it goes?

@noomorph
Copy link
Collaborator

@matinzd please revert xcode changes first. 🙏

@matinzd
Copy link
Contributor Author

matinzd commented Dec 13, 2024

Done!

@matinzd
Copy link
Contributor Author

matinzd commented Dec 13, 2024

I guess I need to fix some stuff. I will do it tomorrow.

@matinzd
Copy link
Contributor Author

matinzd commented Dec 16, 2024

Made updates and resolved some test failures, though a few tests are still failing. Please feel free to push to my branch or advise on necessary changes.

@thomashohn
Copy link

It would be really nice to have this one fixed

@noomorph
Copy link
Collaborator

noomorph commented Dec 18, 2024

Well, the drop-in replacement does not fit as advertised. I need to find a bit more time to fix the remainder. 🤷‍♂️

@thomashohn
Copy link

Ok - that was also what I concluded when I had a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants