Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iOS): support react native new architecture. #4661

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

feat(iOS): support react native new architecture. #4661

wants to merge 48 commits into from

Conversation

asafkorem
Copy link
Contributor

@asafkorem asafkorem commented Dec 16, 2024 •
edited
Loading

Support RN new-arch on iOS

  • Add support from Detox test-app for React Native new architecture.
  • Update scripts and CI pipeline to test RN 76 + new architecture.
  • Add new-arch support from Detox

@asafkorem asafkorem self-assigned this Dec 16, 2024
@asafkorem asafkorem force-pushed the test/support-react-native-new-arch branch 2 times, most recently from 2431a36 to d8a5d9c Compare December 22, 2024 14:28
@asafkorem asafkorem force-pushed the test/support-react-native-new-arch branch 2 times, most recently from e09f58a to 40dde14 Compare January 1, 2025 11:31
asafkorem added 25 commits January 1, 2025 18:48
@asafkorem
temp: migrate test-app ios files to ios-old.
b3529f4
@asafkorem
test(app): create new iOS project from template.
1cc1f6b
@asafkorem
test(ios): remove example native tests.
09eebd8
@asafkorem
chore(ios): update git to ignore generated files.
687ff84
@asafkorem
test(ios): update app's bundle-id and build commands.
b6df6c9
@asafkorem
test(ios): link Detox framework with project.
7cad1c8
@asafkorem
test(ios): update Podfile with dependencies.
35cdb2d
@asafkorem
test(ios): update AppDelegate.mm with deps.
b8a4b2f
@asafkorem
test(ios): add NativeModule.
336d83d
@asafkorem
test(ios): refactor legacy NativeModule.
c8589fa
@asafkorem
test(ios): add background modes capabilities.
294a164
@asafkorem
test(ios): enable upside-down rotation.
47625f0
@asafkorem
test(ios): update Info.plist with missing keys.
d1800f1
@asafkorem
test(ios): copy command line arguments from legacy ios project.
e54f558
@asafkorem
feat(iOS): support new RCTScrollViewComponentView.
23edfc9
@asafkorem
feat(ios): support new-arch's RCTParagraphComponentView.
488c203
@asafkorem
feat(ios): support React Native new arch app-reloading.
67e1f60
@asafkorem
test(ios): add example-ci scheme (no Detox linkage).
ba95461
@asafkorem
test(ios): refactor Podfile.
d7f7f97
@asafkorem
chore(deps): update DetoxSync with new-arch sync support.
23c726a
@asafkorem
chore(ios): add manual test env vars for debugging.
5492e6a
@asafkorem
test(ios): fix test-app Podfile.
bdcddea
@asafkorem
test(ios): fix test-app Podfile.
6c280b8
@asafkorem
test(ios): update binary path to the non-detox-linked app (example-ci).
bcea8cd
@asafkorem
fix(ios): temporary remove text fix for predicate.
abca5b9
asafkorem added 19 commits January 1, 2025 18:48
@asafkorem
fix(ios): support new RCTParagraphComponentView component.
2fd21b0
@asafkorem
test: enable new arch from the Podfile.
824c053
@asafkorem
test(RN .76): update view-hierarchy snapshot tests.
e5f0127
@asafkorem
fix(iOS): fix implicit conversion of Integer in Podfile.
fc625fd
@asafkorem
fix(ios): remove RCT_NEW_ARCH_ENABLED assignment from Podfile.
263a85f 
not needed as can be empty for no-new-arch.
@asafkorem
fix: make keyboard tests pass on legacy arch.
b5bd5b4
@asafkorem
refactor(iOS): AppDelegate extensions.
28358fb
@asafkorem
fix: support background searchable items.
4dbe3c4
@asafkorem
chore: update detox-copilot cache.
35ba68a
@asafkorem
test: update image snapshot tests.
594c66c
@asafkorem
test(ios): support shake events from test-app.
9c7b542
@asafkorem
test(app): support stack view for toasts.
d4fe2ad
@asafkorem
test: fix test text matcher.
c27a003
@asafkorem
test(app): remove old iOS code.
88f22ff
@asafkorem
test(podfile): remove old RN versions check.
d8ec159
@asafkorem
chore: clean old snapshot test artifacts.
865645d
@asafkorem
revert(test): use old string for native root native module.
c469c8b
@asafkorem
test: remove old RN workarounds from podfile.
58e7757
@asafkorem
test: update snapshots.
207673c
@asafkorem asafkorem force-pushed the test/support-react-native-new-arch branch 2 times, most recently from 683edaf to cc454a6 Compare January 2, 2025 09:04
@asafkorem asafkorem force-pushed the test/support-react-native-new-arch branch from cc454a6 to cb35ca8 Compare January 2, 2025 10:15
@asafkorem asafkorem force-pushed the test/support-react-native-new-arch branch from cb35ca8 to abb9ae4 Compare January 2, 2025 13:12
@asafkorem asafkorem marked this pull request as ready for review January 2, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4vidi d4vidi Awaiting requested review from d4vidi d4vidi is a code owner

@noomorph noomorph Awaiting requested review from noomorph noomorph is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@asafkorem asafkorem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asafkorem