android(feat):new arch support #4675

gosha212 · 2024-12-24T16:21:39Z

Description

This pull request addresses the issue described here: RN New-Arch (Fabric) Compatibility #4175

In this pull request, I have added support for the new arch in detox

For features/enhancements:

I have added/updated the relevant references in the documentation files.

For API changes:

I have made the necessary changes in the types index file.

# Conflicts: # detox/android/detox/src/full/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt

Change the way of getting is fabric enabled

.buildkite/jobs/pipeline.android_demo_app_rn_76.yml

asafkorem · 2025-01-13T07:38:07Z

@gosha212 I think the test app will crash on the Localization screen on Android, since it uses a legacy native module.
If we're not testing that due to unsupported features it might be better to disable this screen on Android

asafkorem · 2025-01-13T15:33:01Z

we should check if our bridge native modules work with backward comp. or if there's something magically /hybrid that happens here

asafkorem

In iOS we can check the env flag process.env.RCT_NEW_ARCH_ENABLED
We can use this when running new arch on android as well (for the tests)

detox/test/e2e/33.attributes.test.js

d4vidi

Overall, great job. Lot's of notes on my end but we are nevertheless very close to finish 👑

detox/android/detox/build.gradle

.buildkite/jobs/pipeline.android_rn_75.yml

.../demo-react-native/android/app/src/androidTest/java/com/example/DetoxTestAppJUnitRunner.java

examples/demo-react-native/android/app/src/main/java/com/example/MainActivity.kt

scripts/change_react_native_version.js

detox/android/detox/src/full/java/com/wix/detox/reactnative/reloader/ReactNativeReloader.kt

...src/full/java/com/wix/detox/reactnative/idlingresources/timers/FabricTimersIdlingResource.kt

…lingresources/uimodule/fabric/FabricUIManagerIdlingResources.kt Co-authored-by: d4vidi <[email protected]>

Co-authored-by: d4vidi <[email protected]>

d4vidi · 2025-01-15T16:20:57Z

detox/android/detox/build.gradle

+    api('androidx.test:core-ktx:1.6.1') {
+        because 'Needed by Detox but also makes AndroidX test core seamlessly provided to Detox users with hybrid apps/E2E-tests.'
+    }
+    api("org.jetbrains.kotlin:kotlin-reflect:$_kotlinVersion") {
+        because('Needed by Detox for kotlin reflection')
+    }


on 2nd thought, maybe implementation would be a better idea here

...om/wix/detox/reactnative/idlingresources/factory/FabricDetoxIdlingResourceFactoryStrategy.kt

.../detox/src/full/java/com/wix/detox/reactnative/idlingresources/timers/JavaTimersReflected.kt

mikehardy · 2025-02-05T02:17:06Z

Hey @gosha212 - just wanted to say thanks for the new arch fixes in detox - I know it's a pain getting the ReactContext because I also had to fight my way through it in react-native-firebase and notifee, with all the symbols being different across versions but you need it to work on all the versions too, what a pain.

I tried the 20.33.0-prerelease.0 release and it works for me (at least with one trivial build.gradle patch that's already tracked here in an issue). 20.32.0 definitely didn't get the react context in new arch mode, but I've got all the correct adb logcat messages now indicating it has it with these PRs in the prerelease 🔥

gosha212 · 2025-02-05T13:38:37Z

@mikehardy thanks for the warm words. The iOS is 99% ready

mikehardy · 2025-02-05T21:49:22Z

react-native-firebase e2e app (my use case here) does almost no app interaction so we are not a great indicator of full-feature functionality, but it's working for us on react-native iOS platform as well as react-native-macos already, for basic app launch / terminate / ready-signaling behavior, so I'm well-pleased. Merged the PR with it already and our e2e app is able to test (and sadly, uncover some) new architecture issues

d4vidi · 2025-02-09T20:14:01Z

@mikehardy thanks again for the kind words! 🙏🏻
On iOS, we've been finalizing some edge cases related to Detox's handling of app crash scenarios.

...able to test (and sadly, uncover some) new architecture issues

Music to our ears... 🎶 whenever tests uncover issues, we feel better about our work 😊

gosha212 added 5 commits December 24, 2024 16:05

Enabled fabric WIP

0a0328f

# Conflicts: # detox/android/detox/src/full/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt

Create isFabric implementation

9b4d3c6

Fixed react native reloader to work with new arch.

bc925ac

WIP

e86edb9

Implemented fabric idling resources

8f379a9

gosha212 changed the title ~~Feat/4175 new arch~~ android(feat):new arch support Dec 24, 2024

gosha212 added 24 commits December 25, 2024 10:27

Updated proguard to support fabric

01aa325

Fixed build for RN 75

1fa2bbd

Fixed tests

93ea9d7

Fixed tests

47d36d4

Fixed storage idling resources

3aa86fd

Fixed timer idling resources build on rn 75 and 74

158f416

Fixed release builds for all rn versions

b0680d0

Fixed timers idling resources reflection

1929161

Fixed timers idling resources reflection

e83a829

Fixed reflection in timers idling resources

9694324

Fixed timers idling resources reflection

1f3f97a

Fixed timers idling resources reflection

af2a963

Fixed timers idling resources reflection

ac8a266

Fixed timers idling resources reflection

d9e4ca0

Fixed screenshot tests

4f3564a

Fixed tests

e58225f

Fixed demo app to work with fabric

41024a8

Change the way of getting is fabric enabled

Fixed demo app to work with fabric

c84e835

Change the way of getting is fabric enabled

Fixed proguard to support release builds

85265eb

Updated gradle wrapper version

d3943bd

Changed pipeline names

178bec8

Changed pipeline names

3de2795

Fixed scripts to support rn 73

36ccf80

Minor refacotring

10a2877

gosha212 added 3 commits January 8, 2025 14:45

Run rn 73 with old arch only

c7138bb

Fixed React Native Loading Monitoring

fef978d

Fixed idling resources raise condition

b21d9d1

asafkorem reviewed Jan 13, 2025

View reviewed changes

.buildkite/jobs/pipeline.android_demo_app_rn_76.yml Outdated Show resolved Hide resolved

gosha212 marked this pull request as ready for review January 13, 2025 09:39

gosha212 requested review from d4vidi and noomorph as code owners January 13, 2025 09:39

gosha212 and others added 2 commits January 13, 2025 11:39

Merge branch 'master' into feat/4175-new-arch

3559343

Fixed idling resources unregistering

db02011

asafkorem requested changes Jan 14, 2025

View reviewed changes

detox/test/e2e/33.attributes.test.js Show resolved Hide resolved

d4vidi requested changes Jan 14, 2025

View reviewed changes

gosha212 and others added 4 commits January 15, 2025 17:12

Fixes after code review

a529708

Update detox/android/detox/src/full/java/com/wix/detox/reactnative/id…

809d8b5

…lingresources/uimodule/fabric/FabricUIManagerIdlingResources.kt Co-authored-by: d4vidi <[email protected]>

Update detox/scripts/updateGradle.js

017f099

Co-authored-by: d4vidi <[email protected]>

Fixes after code review

dfa9664

d4vidi reviewed Jan 15, 2025

View reviewed changes

...om/wix/detox/reactnative/idlingresources/factory/FabricDetoxIdlingResourceFactoryStrategy.kt Outdated Show resolved Hide resolved

d4vidi reviewed Jan 15, 2025

View reviewed changes

.../detox/src/full/java/com/wix/detox/reactnative/idlingresources/timers/JavaTimersReflected.kt Show resolved Hide resolved

gosha212 and others added 4 commits January 16, 2025 14:45

Fixes after pr

1c4e599

Fixed async storage implementation and tests in Android

6badd27

Fixed it.todo

5fd3854

Merge branch 'master' into feat/4175-new-arch

e5e1002

gosha212 merged commit 0e77622 into master Jan 16, 2025
2 of 3 checks passed

gosha212 deleted the feat/4175-new-arch branch January 16, 2025 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

android(feat):new arch support #4675

android(feat):new arch support #4675

gosha212 commented Dec 24, 2024

asafkorem commented Jan 13, 2025 •

edited

Loading

asafkorem commented Jan 13, 2025

asafkorem left a comment •

edited

Loading

d4vidi left a comment

d4vidi Jan 15, 2025

gosha212 Jan 16, 2025

mikehardy commented Feb 5, 2025

gosha212 commented Feb 5, 2025

mikehardy commented Feb 5, 2025

d4vidi commented Feb 9, 2025 •

edited

Loading

android(feat):new arch support #4675

android(feat):new arch support #4675

Conversation

gosha212 commented Dec 24, 2024

Description

asafkorem commented Jan 13, 2025 • edited Loading

asafkorem commented Jan 13, 2025

asafkorem left a comment • edited Loading

Choose a reason for hiding this comment

d4vidi left a comment

Choose a reason for hiding this comment

d4vidi Jan 15, 2025

Choose a reason for hiding this comment

gosha212 Jan 16, 2025

Choose a reason for hiding this comment

mikehardy commented Feb 5, 2025

gosha212 commented Feb 5, 2025

mikehardy commented Feb 5, 2025

d4vidi commented Feb 9, 2025 • edited Loading

asafkorem commented Jan 13, 2025 •

edited

Loading

asafkorem left a comment •

edited

Loading

d4vidi commented Feb 9, 2025 •

edited

Loading