-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Android): Kotlin build issues with RN 0.75.3 #7913
base: master
Are you sure you want to change the base?
fix(Android): Kotlin build issues with RN 0.75.3 #7913
Conversation
134ba34
to
21811c0
Compare
I found 2 new errors :
|
updated in react native here -> https://github.com/facebook/react-native/pull/39630/files
d510996
to
f1bae0f
Compare
I've just tested it and got:
|
@zabojad : probably you missed a |
hey @siddarthkay ! I've applyied the fix directly from this PR (I did not change any file manually before testing it). Also, when double checking the files of this PR, we see the missing '}' there: Anyway... It's not a big deal, I just wanted to tell you so that you fix your PR... |
in react-native-reanimated resolved like this
|
Any chance this can get verified and merged? I've ran into this issue in a project I'm working on and am kind of blocked until this is resolved. |
Second that, any hope this can get merged? Not being able to use the two most recent versions of RN is pretty rough. |
@asafkorem can you check this one please |
Summary
This PR fixes the following Kotlin build issues which were discovered after I upgraded
react-native
to0.75.3
andreact-native-navigation
to7.40.1
fixes: #7905, #7911