Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android build for RN 0.72 #990

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix android build for RN 0.72 #990

merged 2 commits into from
Sep 13, 2023

Conversation

jshiherlis
Copy link
Contributor

Fix #975
#975

Replace deprecated method setEnabled by required.set()
Use getRequired().set() instead.

@jshiherlis jshiherlis marked this pull request as draft August 13, 2023 10:16
@jshiherlis jshiherlis marked this pull request as ready for review August 13, 2023 10:16
kacgrzes
kacgrzes approved these changes Aug 18, 2023
View reviewed changes
Copy link

@kacgrzes kacgrzes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me

@arashkevich25
Copy link

@DanielEliraz can we merge it ?

@mdidehbanmehr
Copy link

Let's merge this please

DanielEliraz
DanielEliraz approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@DanielEliraz DanielEliraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DanielEliraz DanielEliraz merged commit 980ce21 into wix:master Sep 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacgrzes kacgrzes kacgrzes approved these changes

@DanielEliraz DanielEliraz DanielEliraz approved these changes

@my-name-is-nheo my-name-is-nheo my-name-is-nheo approved these changes

Assignees
No one assigned
Labels
type: accepted/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error after upgrading to React Native 0.72
6 participants
@jshiherlis @arashkevich25 @mdidehbanmehr @kacgrzes @DanielEliraz @my-name-is-nheo