usage section should show LivePreview or CodeBlock #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Dec 12, 2024
| if (component.snippet) { | ||
| return ( | ||
| return componentLivePlaygroundSupport ? ( |
There was a problem hiding this comment.
You can simplify: return componentLivePlaygroundSupport ? <UILivePreview code={code}/> : <CodeBlock language="jsx">{code}</CodeBlock>;
|
@adids1221 Is this PR ready for review? I see I'm a reviewer but it's still on draft and I'm not assigned to it... Anyways wrote a small comment |
|
@Inbal-Tish I'll ask Miki first about it, after that I'll the PR will be ready for review. @M-i-k-e-l WDYT about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs -
Usagesection, should show live playground or code block.If the component is part of the
ReactLiveScopewe should show live playground else code block.Changelog
Docs -
Usagesection, should show live playground or code block.Additional info
None