Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong units in remaining time warning #1229

Merged

Conversation

edouardparis
Copy link
Member

close #1226

Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK c70a5cb
I included the reported testcase

@edouardparis edouardparis merged commit 39c0458 into wizardsardine:master Aug 14, 2024
21 checks passed
@edouardparis edouardparis deleted the fix-1226-wrong-remaining-time branch August 14, 2024 13:22
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong display of remaining time if remaining time nearly 1 year
2 participants