Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify UI of Welcome screen #1232

Closed
wants to merge 2 commits into from
Closed

Conversation

ktecho
Copy link

@ktecho ktecho commented Aug 18, 2024

In the welcome screen, Liana has this:

image

Each option has a text that implies an action, and then a button with the action text "Select". The UI can be changed and simplified so it only reflects the two actions that can be chosen. The end result would be this one:

image

And when putting the mouse over the button:

image

@edouardparis
Copy link
Member

edouardparis commented Aug 20, 2024

Thank you for the PR. Sadly we cannot use it as it is because we are trying to have a UX/UI development process where design choices are discussed first with our product manager, designers and helpful users.

@ktecho
Copy link
Author

ktecho commented Aug 20, 2024

Thank you for the PR. Sadly we cannot use it as it is because we are trying to have a UX/UI development process where design choices are discussed first with our product manager, designers and helpful users.

I understand, no problem.

What should I have done? I'm in Liana's Discord. Should I have suggested it first there? Thanks!

@nondiremanuel
Copy link
Collaborator

nondiremanuel commented Aug 20, 2024

Thank you for the PR. Sadly we cannot use it as it is because we are trying to have a UX/UI development process where design choices are discussed first with our product manager, designers and helpful users.

I understand, no problem.

What should I have done? I'm in Liana's Discord. Should I have suggested it first there? Thanks!

Thanks for the contribution and the interest. Yes, discussing it via discord could be a good way. In this specific case, for example, we are already designing a new layout for that screen, which would make the work on this PR short-living.

A good way could also be to take some issues from the "Good first issue" basket, especially the ones related to the GUI: https://github.com/wizardsardine/liana/issues?q=is%3Aopen+is%3Aissue+label%3A%22Good+first+issue%22
Those can also be discussed directly in each specific github issue.

@ktecho
Copy link
Author

ktecho commented Aug 20, 2024

Perfect, thanks.

@ktecho ktecho closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants