-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check coldcard version and request user to upgrade #1346
Check coldcard version and request user to upgrade #1346
Conversation
080ce88
to
7371c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 7371c9d.
gui/ui/src/component/hw.rs
Outdated
column(vec![ | ||
text::p1_bold("Unsupported firmware version").into(), | ||
text::p1_regular(format!( | ||
"Install version superior or equal to {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it would sound more natural to say "Install version {} or later".
We avoid to add more logic for now, it is past rc and goes straight into release and we have the taproot support warning when user uses the taproot dropdown. |
tACK 7371c9d |
7371c9d
to
7124e09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 7124e09.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-ACK 7124e09
47b8ad2 Check coldcard version and request user to upgrade (edouardparis) Pull request description: backport of #1346 ACKs for top commit: jp1ac4: utACK 47b8ad2. edouardparis: Self-ACK 47b8ad2 Tree-SHA512: a11e24928e5ad5aa268bb216563ec7c35fb95cbed14032b3fd4d099983dcc52473efd216ebe659e8beade18d0c6c7b26db5e1b479f5a6f2676b4d5965600f5bc
Close #1343