Update rust-miniscript (and thereby rust-bitcoin) to latest version
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
update_miniscript
branch
2 times, most recently
from
677e995
to
cd47e99
Compare
darosior
changed the title
rust-miniscript (and thereby rust-bitcoin) to latest version
darosior
force-pushed
the
update_miniscript
branch
2 times, most recently
from
3c033c9
to
d97152e
Compare
darosior
commented
Jul 13, 2023
Rust-bitcoin, that we use through rust-miniscript, has seen plenty of breaking changes in the latest version. I've tried to keep the necessary changes here minimal, still it had to be a single commit to keep it hygienic. But i'll try to summarize the main things here. Tobin also wrote a guide about the release at https://rust-bitcoin.org/blog/release-0.30.0/. The most verbose change in this commit is probably due to the `Address` type overhaul. It's overengineered if you ask me but hey here we are. I tried to keep network validation in commands, and otherwise passing around unchecked addresses (to avoid having to pass around a global state between our various components). Another non-obvious change was changes in hash types upstream and the removal of `ToHex`, forcing us to get the hex representation of a txid through its `Display` implementation. It is however displayed backward in this case ("little-endian" if you will), and we need a regular hex encoding for some queries to the database. We needed to make sure we didn't implement any silent bug here. The rest (Script type changes, PSBT serialization updates, ..) is probably self-explanatory.
For some reason it started warning about them after the upgrade of rust-miniscript.
The latest rust-miniscript version deprecated the helper we were using, in favour of one that gives the maximum size difference of a transaction input before and after satisfaction. The new helper differs in that it does not account for the empty ScriptSig byte (which uncovered we were actually double-counting it), and assumes the non-satisfied transaction input is already part of a Segwit transaction (which we rectified). This uncovered a mistake in the computation of the witness script size in the unit test. We also get rid of the needless wu_to_vb() standalone function.
rust-bitcoin now takes care of that.
darosior
force-pushed
the
update_miniscript
branch
from
3e04d4b
to
a19f2c1
Compare
|
Self-ACK a19f2c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a big chunk, especially in making sure we don't introduce any silent bug with all the upstream recent code movements.
Also, we no longer depend on my custom
rust-miniscriptbranch! 🎉