commands: add weights before converting to vbytes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting to vbytes first can lead to a larger result and therefore a lower feerate, which could fall below 1 and fail the sanity check.
darosior
reviewed
Oct 20, 2023
| @@ -17,7 +17,7 @@ pub use keys::*; | |||
| pub mod analysis; | |||
| pub use analysis::*; | |||
|
|
|||
| const WITNESS_FACTOR: usize = 4; | |||
| pub const WITNESS_FACTOR: usize = 4; | |||
There was a problem hiding this comment.
In the future we should avoid rolling our own constant and instead use rust-bitcoin's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sanity_check_psbt()function checks, among other things, that the feerate in sats/vbytes is in the required range. When estimating the transaction size, converting each part to vbytes first can lead to a larger result due to rounding multiple times and therefore a lower feerate, which could fall below 1 and fail the sanity check.This issue has arisen in #560 when creating a transaction using coin selection.