Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

[FIX] actually build jammy, not bionic #122

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

StefanRijnhart
Copy link
Contributor

Fixes: #121

Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @StefanRijnhart! Very embarrassing copy-paste fail 🙈

@ashkulz ashkulz merged commit 4e7e471 into wkhtmltopdf:master Jun 23, 2022
@StefanRijnhart
Copy link
Contributor Author

Well, more embarrasment on my side, I'm now actually trying to build wkhtmltox for the first time myself, and it seems that Jammy needs to install python3 instead of python in its dockerfile. I can propose a fix (once I managed to run the build successfully myself), but what would be the best way to codify this? Would you like a new Dockerfile.debian.python3 with the packages swapped out?

Package python is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  python2-minimal python2 dh-python 2to3 python-is-python3

@ashkulz
Copy link
Member

ashkulz commented Jun 23, 2022

@StefanRijnhart I canceled the run to build the binaries. I think the cleanest way is to add an ARG python=python at the start of Dockerfile.debian and pass in python: python-is-python3 in build.yml which should hopefully pull in python3 as well.

@ashkulz
Copy link
Member

ashkulz commented Jun 23, 2022

Let me know if you figure it out, else I'll see if I can do it early tomorrow -- have a birthday in the family today 😄

@StefanRijnhart
Copy link
Contributor Author

@ashkulz thank you for your guidance. Using an ARG for the python package seems to work. Will propose when the build has finished. Please prioritize family, it is important.

@StefanRijnhart
Copy link
Contributor Author

#123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New Jammy builds are against old version of SSL
2 participants