Don't use mmap below a certain size threshold #36
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mmap` is slower than copying for small buffers. With this commit, if the size of the buffer is below some threshold we'll use `write` and `read` to payload/depayload. We still use an FD transport in this case though. I've set the threshold to 100KB, but it is customiseable via the `TMPFILE_MMAP_THRESHOLD` environment variable so we can experiment with different values easily.
Owner
Author
|
I couldn't measure any significant performance difference with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmapis slower than copying for small buffers. With this commit, if thesize of the buffer is below some threshold we'll use
writeandreadto payload/depayload. We still use an FD transport in this case though.
I've set the threshold to 100KB, but it is customiseable via the
TMPFILE_MMAP_THRESHOLDenvironment variable so we can experiment withdifferent values easily.
This is an alternative to #35.