Add new Use of Funds modal to all banners #713
+615
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix styles for desktop - Add missing colours Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
a0ccc74 to
39eabac
Compare
- Add dark mode to new use of funds Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
502803f to
46249c0
Compare
Abban
changed the title
Abban
force-pushed
the
new-use-of-funds
branch
2 times, most recently
from
643b504 to
ae50baf
Compare
- Remove unused infographic component - Tweak styles to make full width work better - Make sure modalOpened and modalClosed only fire once per modal - Add UoF tests, and separate mobile and desktop Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
ae50baf to
eaa2059
Compare
- Improve scrolling functionality and tests - Fix tests for clos events in FillPageBanner and BannerConductor - Add minerva skin to uof swatch - Add missing modal opened and closed events Ticket: https://phabricator.wikimedia.org/T381956
- Adds new UoF and tests - Sets form back to fixed width Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
82d0626 to
ed7c7a3
Compare
- Adds new UoF and tests - Fixes LocaleFactory Ticket: https://phabricator.wikimedia.org/T381956
- Adds new UoF and tests Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
4a32724 to
5801c7f
Compare
This allows us to put text for screen readers alongside button icons. Added close text to the messages and hooked up the main and UoF close buttons. Ticket: https://phabricator.wikimedia.org/T381956
Abban
force-pushed
the
new-use-of-funds
branch
from
5801c7f to
308c00b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://phabricator.wikimedia.org/T381956