Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Merge Software by ID #55

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Merge Software by ID #55

wants to merge 11 commits into from

Conversation

RickiJay-WMDE
Copy link
Member

No description provided.

@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review January 11, 2025 00:41
@RickiJay-WMDE RickiJay-WMDE requested a review from rti January 11, 2025 00:41
@@ -12,6 +12,7 @@
create_software_version_observation,
create_special_statistics_observation,
create_user_observation,
merge_software_by_id,
Copy link
Collaborator

@rti rti Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it see it correctly, that the merging is something that the user has to do manually?

Could you please shortly describe the workflow this feature would allow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. This is strictly a manual process.
On identification of a duplicate extension - such as Discord Notifications with and without space, or Miraheze Magic and <extensionname-mirahezemagic>, both of which we've actually encountered in this project - this would allow us to merge the two records. We call the first record "base" and the second "additional", and pass in the baseId and additionalId.
All of the software version records collected from wikibases that referred to the additional software would be shifted over to the base software. Any tags collected from Mediawiki for the additional would also be shifted to the base (avoiding duplicates, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants