- Fix incorrect Quick Info for qualified C# constructors

wmjordan · Feb 7, 2024 · 6051aeb · 6051aeb
1 parent d866947
commit 6051aeb
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/Codist/QuickInfo/CSharpQuickInfo.cs b/Codist/QuickInfo/CSharpQuickInfo.cs
@@ -67,7 +67,8 @@ async Task<QuickInfoItem> InternalGetQuickInfoItemAsync(IAsyncQuickInfoSession s
 				? QuickInfoOverride.CreateOverride(session)
 				: null;
 			var container = new InfoContainer();
-			ClassifyToken:
+			ObjectCreationExpressionSyntax ctor = null;
+		ClassifyToken:
 			switch (token.Kind()) {
 				case SyntaxKind.WhitespaceTrivia:
 				case SyntaxKind.SingleLineCommentTrivia:
@@ -286,7 +287,6 @@ async Task<QuickInfoItem> InternalGetQuickInfoItemAsync(IAsyncQuickInfoSession s
 					return null;
 			}
 
-			ObjectCreationExpressionSyntax ctor;
 		PROCESS:
 			if (Config.Instance.QuickInfoOptions.MatchFlags(QuickInfoOptions.Parameter)) {
 				ShowParameterInfo(container, node, semanticModel, cancellationToken);
@@ -342,10 +342,10 @@ async Task<QuickInfoItem> InternalGetQuickInfoItemAsync(IAsyncQuickInfoSession s
 				if (isConvertedType == false) {
 					container.Add(await ShowAvailabilityAsync(ctx.Document, token, cancellationToken).ConfigureAwait(false));
 				}
-				ctor = node.Parent as ObjectCreationExpressionSyntax;
+				ctor = node.Parent.UnqualifyExceptNamespace() as ObjectCreationExpressionSyntax;
 				OverrideDocumentation(node,
 					o,
-					ctor?.Type == node
+					ctor != null
 						? semanticModel.GetSymbolInfo(ctor, cancellationToken).Symbol ?? symbol
 						: symbol,
 					semanticModel,
@@ -358,8 +358,10 @@ async Task<QuickInfoItem> InternalGetQuickInfoItemAsync(IAsyncQuickInfoSession s
 				ShowSymbolInfo(session, container, node, symbol, semanticModel, cancellationToken);
 			}
 		RETURN:
-			ctor = node.Parent as ObjectCreationExpressionSyntax;
-			if (ctor != null && ctor.Type == node) {
+			if (ctor == null) {
+				ctor = node.Parent.UnqualifyExceptNamespace() as ObjectCreationExpressionSyntax;
+			}
+			if (ctor != null) {
 				symbol = semanticModel.GetSymbolOrFirstCandidate(ctor, cancellationToken) ?? symbol;
 				if (symbol == null) {
 					return null;