Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rsa modulus endianess to match most protocols #66

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jul 12, 2023

Most protocols encode the RSA modulus in big-endian format.
E.g.

merge order

  1. This PR
  2. Remove namefilter.md and add NameAccumulator verification algorithm #68
  3. Specify Blake3's derive_key algorithm instead of SHA3 #69
  4. Switch from AES-GCM to XChaCha20-Poly1305 #70
  5. Add baseName to ExternalContent #71

@matheus23 matheus23 requested a review from expede as a code owner July 12, 2023 16:38
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2023
@matheus23 matheus23 self-assigned this Jul 14, 2023
Copy link
Member

@expede expede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one suggestion, but LGTM! 🚢

@matheus23 matheus23 merged commit cd7e9bd into main Aug 11, 2023
@matheus23 matheus23 deleted the matheus23/update-rsa-endianess branch August 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants