Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull latest zopfli as git submodule + Python 3 support #9

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

anthrotype
Copy link

Hi,

Thank your for this project!

I'm interested in making the Python bindings up to date with zopfli's upstream repo, and also make it work on both Python 2 and 3, and on both unix and win32 platforms.

I would like to use zopfli instead of zlib for compressing WOFF 1.0 fonts in fonttools, a font manipulation library written in Python: fonttools/fonttools#491

Here I applied the following changes:

  • I included google/zopfli repository as a git submodule. I think this is better than embedding copies of the source files. Whenever the upstream project is updated, you only need to checkout the latest commit from the submodule.
  • I made some changes to allow the extension module to work on both Python 2 and 3, following the same approach as the other compression project by Google, Brotli -- to which I've also contributed.

Please let me know if this is ok.
Thanks,

Cosimo

@moyogo
Copy link

moyogo commented Apr 13, 2016

@adamdeprince ping?
It would be nice to have an updated version on pypi.

@adamdeprince
Copy link
Contributor

My write access to this repo was terminated when I resigned from WNYC in 2014. I'll fork this and we can work from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants