fix(Page): prevent crash when document fails to load#2090
Open
cyphercodes wants to merge 1 commit intowojtekmaj:mainfrom
Open
fix(Page): prevent crash when document fails to load#2090cyphercodes wants to merge 1 commit intowojtekmaj:mainfrom
cyphercodes wants to merge 1 commit intowojtekmaj:mainfrom
Conversation
When the Document component fails to load a PDF, it sets pdf to false. The Page component was throwing an invariant error when pdf was false, causing the entire UI to crash even when error handlers were provided. This change allows pdf to be false (indicating a load error) and lets the renderContent() function handle it gracefully by showing the error message instead of throwing. Fixes wojtekmaj#2051
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the Document component fails to load a PDF (e.g., 403 or 404 error), it sets
pdftofalse. The Page component was throwing an invariant error whenpdfwasfalse, causing the entire UI to crash even when error handlers were provided.The Problem
Users reported that when a document fails to load with an error, the whole UI crashes even though they have error handlers in place:
The Fix
Changed the invariant check from:
to:
This allows
pdfto befalse(indicating a load error) and lets therenderContent()function handle it gracefully by showing the error message instead of throwing an error.Changes
pdf === falserenderContent()already handlespdf === falsecorrectlyFixes #2051