Fixes to sign.c running on windows #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use generic buffer API to ensure that the files are open with the right flags. Non-POSIX systems would require `open()` to use an extra O_BINARY flag to ensure the file is properly processed and sizes calculated accordingly. As file descriptors are only needed in mmap() mode, the win32 interface is reworked to use `fopen()` instead. Thanks to Erik Chang for reporting this issue.
danielinux
force-pushed
the
fix_windows_keytools
branch
from
17ae319 to
e6e3afa
Compare
… of `WOLFBOOT_SECTOR_SIZE` for delta support.
dgarske
previously approved these changes
Aug 18, 2023
dgarske
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use generic buffer API to ensure that the files are open with the right flags.
Non-POSIX systems would require
open()to use an extra O_BINARY flag to ensure the file is properly processed and sizes calculated accordingly. As file descriptors are only needed in mmap() mode, the win32 interface is reworked to usefopen()instead.Thanks to Erik Chang for reporting this issue.