Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfHSM support for ML-DSA #523

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

bigbrett
Copy link
Contributor

@bigbrett bigbrett commented Dec 3, 2024

  • Adds wolfHSM offload for ML-DSA
  • Consolidates AURIX helper scripts into wbaurixtool.sh, a one-stop-shop configuration tool that handles the manual configuration steps that aren't handled by AURIX IDE
  • Various AURIX project configuration improvements

Note that this requires updating wolfSSL to include wolfSSL/wolfssl#8177 and wolfSSL/wolfssl#8229. If we need to wait until the required changes are incorporated in a release, let me know and this can remain a draft PR

@bigbrett bigbrett marked this pull request as draft December 3, 2024 20:01
@bigbrett
Copy link
Contributor Author

bigbrett commented Dec 3, 2024

Converting to draft until @danielinux merges #521

- consolidate AURIX scripts into wbaurixtool.sh
- documentation updates
@bigbrett
Copy link
Contributor Author

bigbrett commented Dec 6, 2024

rebased after #521 was merged, re-tested on Sim + AURIX. Ready for review

@bigbrett bigbrett marked this pull request as ready for review December 6, 2024 19:51
@bigbrett bigbrett requested review from danielinux and dgarske and removed request for danielinux December 6, 2024 19:51
tools/keytools/keygen.c Outdated Show resolved Hide resolved
dgarske
dgarske previously approved these changes Dec 9, 2024
tools/keytools/keygen.c Outdated Show resolved Hide resolved
tools/keytools/keygen.c Show resolved Hide resolved
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. over to @danielinux

Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove dead config block

include/user_settings.h Show resolved Hide resolved
@danielinux danielinux merged commit 638787e into wolfSSL:master Dec 16, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants